Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _index.md #47942

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ayushpatil2122
Copy link
Contributor

Description

Early Kubernetes used an annotation, autoscaling.alpha.kubernetes.io/behavior. However it's not officially registered.
Proposed Solution:
We should register the annotation, marking it deprecated.

Issue

#47874

Page Updated: #
https://kubernetes.io/docs/reference/labels-annotations-taints/

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign drewhagen for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Sep 15, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 15, 2024
Copy link

netlify bot commented Sep 15, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit bff6274
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66e731f2d955d8000850862a
😎 Deploy Preview https://deploy-preview-47942--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

it is an alpha feature and is not officially registered, having been replaced by the stable behavior field in the HPA v2beta2 API.

{{< note >}}
This annotation is now deprecated and should not be used in new configurations.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be aware that we don't document things that are older than 4 releases.
Even if the annotation does fall into this range, we need to clearly state the
releases that support this annotation. Or else, adding this annotation only helps
confusing the users.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then i just need to add the title autoscaling.alpha.kubernetes.io/behavior and marking it deprecated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants